Skipping passphrase screen when no passphrase is available #4115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…assphrase screen fixed by handling the back case to skip the passphrase screen if we don't have one
…te and back flow - introduces a temporary workaorund the unit tests Mavericks by including a no op LifecycleRegistry - manually sets instant rx schedulers via the static helpers, the layers that set the schedulers are not currently injectable
ouchadam
commented
Sep 29, 2021
| copy( | ||
| step = SharedSecureStorageViewState.Step.EnterPassphrase | ||
| ) | ||
| if (state.hasPassphrase) { |
Contributor
Author
There was a problem hiding this comment.
this block is the fix, everything else in this PR is for the unit tests
bmarty
approved these changes
Sep 29, 2021
Member
bmarty
left a comment
bmarty
left a comment
There was a problem hiding this comment.
LGTM, thanks for improving / setting up a better test environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3898
When an key info response doesn't contain a passphrase the login verification flow would still attempt to visit the passphrase screen when going back
Fixed by simply checking if a passphrase is available when going back and dismissing if no passphrase is available
SharedSecureStorageViewModelTest, these tests also found an issue where we're postingViewEventsas part of theViewModelinit flow, this is problematic because we're unable to register an observer beforeinitis called (will raise a separate issue)** logging into an account which doesn't have a passphrase set