Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus on search bar when opening reaction view #4092

Merged
merged 2 commits into from
Sep 29, 2021
Merged

Focus on search bar when opening reaction view #4092

merged 2 commits into from
Sep 29, 2021

Conversation

ryg-git
Copy link
Contributor

@ryg-git ryg-git commented Sep 27, 2021 •
edited
Loading

Pull Request Checklist

Screenrecorder-2021-09-27-23-24-42-14.mp4

Signed-off-by: Yashawant [email protected]

@bmarty
Copy link
Member

bmarty commented Sep 28, 2021

Related to #3869

@ouchadam
Copy link
Contributor

thanks for this, LGTM!

does this fall under bugfix or feature though? 🤔

@ryg-git ryg-git marked this pull request as ready for review September 28, 2021 13:14
@ryg-git
Copy link
Contributor Author

ryg-git commented Sep 28, 2021

Thank you @ouchadam,

I thought it is a bug fix but let me know if I need to change the changelog file.

bmarty
bmarty approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!
Let's keep the changelog like that for now :)

@bmarty bmarty merged commit 856fc8f into element-hq:develop Sep 29, 2021
@github-actions
Copy link

Unit Test Results

  42 files  ±0    42 suites  ±0   47s ⏱️ ±0s
  83 tests ±0    83 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
220 runs  ±0  220 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 856fc8f. ± Comparison against base commit 856fc8f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryg-git @bmarty @ouchadam