Room details: check power level before displaying actions in the timeline #3971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Florian14
force-pushed
the
feature/fre/room_details_power_level
branch
from
0bbba30
to
991609a
Compare
bmarty
reviewed
Sep 7, 2021
...rc/main/java/im/vector/app/features/home/room/detail/timeline/item/MergedRoomCreationItem.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/im/vector/app/features/home/room/detail/timeline/item/MergedRoomCreationItem.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/im/vector/app/features/home/room/detail/timeline/item/MergedRoomCreationItem.kt
Outdated
Show resolved
Hide resolved
Florian14
force-pushed
the
feature/fre/room_details_power_level
branch
from
991609a
to
32303af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3959
User power-level is now checked before showing action as set a topic or invite people to a room.
Previously, an error dialog was shown after the forbidden action, making a bad user experience.