Spaces | Default to 'Home' in settings #3765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
force-pushed
the
feature/bca/m11.12
branch
from
e8ecd54 to
edf0f6e
Compare
bmarty
requested changes
Aug 23, 2021
Member
bmarty
left a comment
bmarty
left a comment
There was a problem hiding this comment.
LGTM, 2 small remarks.
Cannot be merged because of lint
| <string name="space_manage_rooms_and_spaces">Manage rooms and spaces</string> | ||
|
|
||
|
|
||
| <string name="labs_space_show_orphan_in_home">Experimental Space - Only show orphans in Home</string> |
Member
There was a problem hiding this comment.
Lint is not happy, you have to remove all the existing translations for this string.
|
|
||
| </im.vector.app.core.preference.VectorPreferenceCategory> | ||
|
|
||
| <im.vector.app.core.preference.VectorPreferenceCategory android:title="@string/spaces_header"> |
Member
There was a problem hiding this comment.
Maybe create a new string for the setting section instead of reusing spaces_header?
BillCarsonFr
added
the
Z-NextRelease
BillCarsonFr
force-pushed
the
feature/bca/m11.12
branch
from
edf0f6e to
27df3e6
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3754
Moved and renamed the lab preference to a regular preference