Complement for #3656 #3699
Merged
Complement for #3656 #3699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when a download was aborted (e.g. due to a bad internet connection), a partly downloaded file was remaining in cache, which would then be delivered upon later requests. This can lead e.g. to chats where images aren't loading. To avoid this, first download files to a temporary file that is not the final cache file, and only rename/move it on finish. Note that if you already have broken downloads, you still need to clear cache once to get rid of them after this commit, but it should not occur anymore afterwards.
Avoid incomplete downloads in cache
Will not always delete part files in case of crashes
| } | ||
| } | ||
|
|
||
| var atomicFileCreator1: AtomicFileCreator? = null |
Member
There was a problem hiding this comment.
Can it be renamed to something like encyptedCachedAtomicFile
Member
Author
There was a problem hiding this comment.
Renamed to atomicFileDownload, it can be a clear file
| } | ||
|
|
||
| var atomicFileCreator1: AtomicFileCreator? = null | ||
| var atomicFileCreator2: AtomicFileCreator? = null |
Member
There was a problem hiding this comment.
Same renamed to clearCachedAtomicFime
Member
Author
There was a problem hiding this comment.
Renamed to atomicFileDecrypt
BillCarsonFr
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3656
CC @SpiritCroc