Feature/fga/auto accept invite #3531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
approved these changes
Jun 21, 2021
| @OnLifecycleEvent(Lifecycle.Event.ON_PAUSE) | ||
| fun entersBackground() { | ||
| compositeDisposable.clear() |
There was a problem hiding this comment.
Never disposed then? this change is a bit weird here.
Maybe move the code from init {} to entersForeground()?
There was a problem hiding this comment.
Nope I want the invites to be accepted when the app is in background so I can receive calls.
Its just to keep a reference to the disposable so it doesn't get GC
| // also auto-join the virtual room if we have a matching native room | ||
| // (possibly we should only join if we've also joined the native room, then we'd also have | ||
| // to make sure we joined virtual rooms on joining a native one) | ||
| session.joinRoom(invitedRoomId) |
There was a problem hiding this comment.
I don't think so, auto join virtual room is not mandatory
| ).size | ||
| var dmInvites = 0 | ||
| var roomsInvite = 0 | ||
| if (!autoAcceptInvites.hideInvites) { |
There was a problem hiding this comment.
Could be nicer if we also had a method autoAcceptInvites.showInvites()
|
|
||
| interface AutoAcceptInvites { | ||
| val isEnabled: Boolean | ||
| val hideInvites: Boolean |
There was a problem hiding this comment.
Default could be = isEnabled in the itf, no?
Also would be nice to add some Kdoc
ganfra
force-pushed
the
feature/fga/auto_accept_invite
branch
from
e209f6e
to
48fa9e1
Compare
bmarty
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces AutoAcceptInvite. It can be enabled at compile time for now.