Convert WidgetService to suspend functions #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
requested changes
Mar 29, 2021
| "set_bot_power" -> setBotPower(mediator, eventData).run { true } | ||
| "set_plumbing_state" -> setPlumbingState(mediator, eventData).run { true } | ||
| "set_widget" -> setWidget(mediator, eventData).run { true } | ||
| "m.sticker" -> pickStickerData(mediator, eventData).run { true } |
There was a problem hiding this comment.
Could you revert the formatting changes please? There is a problem in the IDE about that, and we have not decided if we want to lose the nice alignment of arrows. The trick is to remove the latest } of the file and type it again. The formatting will be restored...
There was a problem hiding this comment.
WOW! You weren't kidding about the trick. 😂
Signed-off-by: Dominic Fischer <[email protected]>
Dominaezzz
force-pushed
the
suspend_functions_4
branch
from
d86e7e9
to
c548a3d
Compare
bmarty
reviewed
Mar 30, 2021
| RoomDetailAction.QuickActionSetAvatar -> handleQuickSetAvatar() | ||
| is RoomDetailAction.SetAvatarAction -> handleSetNewAvatar(action) | ||
| RoomDetailAction.QuickActionSetTopic -> _viewEvents.post(RoomDetailViewEvents.OpenRoomSettings) | ||
| is RoomDetailAction.ShowRoomAvatarFullScreen -> { |
bmarty
reviewed
Mar 30, 2021
| WidgetAction.LoadFormattedUrl -> loadFormattedUrl(forceFetchToken = false) | ||
| WidgetAction.DeleteWidget -> handleDeleteWidget() | ||
| WidgetAction.RevokeWidget -> handleRevokeWidget() | ||
| WidgetAction.OnTermsReviewed -> loadFormattedUrl(forceFetchToken = false) |
Signed-off-by: Dominic Fischer <[email protected]>
bmarty
reviewed
Mar 30, 2021
| R.id.video_call -> callManager.getCallsByRoomId(state.roomId).isEmpty() | ||
| R.id.hangup_call -> callManager.getCallsByRoomId(state.roomId).isNotEmpty() | ||
| R.id.search -> true | ||
| R.id.dev_tools -> vectorPreferences.developerMode() |
Signed-off-by: Dominic Fischer <[email protected]>
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dominic Fischer [email protected]
Pull Request Checklist