Convert IdentityService to suspend functions #3069
Conversation
| } | ||
|
|
||
| return taskExecutor.executorScope.launchToCallback(coroutineDispatchers.main, callback) { | ||
| withContext(coroutineDispatchers.main) { |
There was a problem hiding this comment.
I'm wondering if this is necessary to keep the withContext() call here (and for other methods too). WDYT?
There was a problem hiding this comment.
Yeah I was thinking about this. We can (and should) drop the withContext here.
To keep things simple I left it in, to mostly preserve previous behaviour.
Once all the callbacks have been converted and everything is consistently marked as suspend, I was planning to review all the uses of withContext and remove the unnecessary ones.
Although....... most of these have been pretty simple so far but I only realized that after like the 9th PR, by which point it was too late 😂.
We can just remove them; I'm at work right now so I can do so in the evening.
Signed-off-by: Dominic Fischer <[email protected]>
Dominaezzz
force-pushed
the
suspend_functions_1
branch
from
e9735dd
to
501b870
Compare
|
Will do that next time. 👍 |
Signed-off-by: Dominic Fischer [email protected]
Pull Request Checklist