-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic filtering for "nsfw" keyword #2975
Conversation
May I have two questions here?
|
"NSFW" is not understandable enough for non power users.
Yes, I have seen the problem with the Blender room, it will be actually filtered out. Filtering like that is far from ideal. This is a first quick implementation, we will do better in the future (filtering server side, new state event describing the room content, etc.) |
Thanks for the quick response!
Maybe "Filter explicit content" or something like that. I would just expect the explicit word to be in the "header". But I am probably just nitpicking at this point... 😂 Sorry for annoying |
I have created https://github.com/matrix-org/matrix-doc/issues/3054 to try to do better on this subject |
FTR I have asked the admin of the room about Blender to update the topic of the room to avoid being filtered by mistake. |
val newPublicRooms = data.chunk.orEmpty() | ||
.filter { | ||
showAllRooms | ||
|| "${it.name.orEmpty()} ${it.topic.orEmpty()} ${it.canonicalAlias.orEmpty()}".toLowerCase(Locale.ROOT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't suggest a better way for now, will think later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, cool!
New settings, in Settings/Preferences screen, off by default:
(Edit: wording has been updated, see new screenshot below)
Filtering room directory
Also migrate RoomDirectoryService to coroutines (#2449)