[issue-2610] implement client-side override of nick color #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow changing the nick color by clicking the dispay-name in the room
member details page.
- the ovirride-color can be specified as a hex string (#rrggbb)
- entering an invalid color code or leaving the field blank reverts to
the default hash-based nick color
- future improvements:
- replace the text-based color entry with a proper color picker dialog
- sync the setting server side so it can be reused by other clients
(although this can cause problems if different themes are used on
the clients)
- make the feature more discoverable
|
|
|
Created a better PR: #2614 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement issue #2610
allow changing the nick color by clicking the dispay-name in the room
member details page.
the ovirride-color can be specified as a hex string (#rrggbb)
entering an invalid color code or leaving the field blank reverts to
the default hash-based nick color
future improvements:
(although this can cause problems if different themes are used on
the clients)
Signed-off-by: Radics Péter [email protected]
Pull Request Checklist