Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert RoomPushRuleService to suspend functions #2382

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Convert RoomPushRuleService to suspend functions #2382

merged 1 commit into from
Nov 13, 2020

Conversation

Dominaezzz
Copy link
Contributor

Signed-off-by: Dominic Fischer [email protected]

Pull Request Checklist

  • Changes has been tested on an Android device or Android emulator with API 21
  • UI change has been tested on both light and dark themes
  • Pull request is based on the develop branch
  • Pull request updates CHANGES.md
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off

bmarty
bmarty approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@bmarty bmarty merged commit a713b97 into element-hq:develop Nov 13, 2020
@Dominaezzz Dominaezzz deleted the suspend_functions_1 branch November 13, 2020 17:44
@bmarty bmarty mentioned this pull request Nov 26, 2020
Open
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dominaezzz @bmarty