Direct share support #2244
Direct share support #2244
Conversation
bmarty
left a comment
bmarty
left a comment
There was a problem hiding this comment.
Thanks a lot for this PR, I have two small remarks.
| .setIntent(intent) | ||
|
|
||
| // Make it show up in the direct share menu | ||
| .setCategories(setOf(directShareCategory)) |
There was a problem hiding this comment.
This is maybe not the ideal place to add this code. create() is called the user create a shortcut, or for the first 4 favorite rooms.
I think other apps create direct share shortcut once something has been shared, for a quicker future sharing to the same target.
There was a problem hiding this comment.
Ok, maybe I have misunderstood this. I think it is OK actuallly
There was a problem hiding this comment.
Such a ranking is still done on the android side (of course only with the shortcuts published to them).
There was a problem hiding this comment.
Yes, my remark was just about what will be the rooms exposed here
vector/src/main/java/im/vector/app/features/share/IncomingShareFragment.kt
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/home/ShortcutCreator.kt
Outdated
Show resolved
Hide resolved
|
Could you add the hacktoberfest topic to the repo as you did at element-web? That would be nice. |
|
What do you mean? |
|
The other matrix repos like synapse or element-web have the hacktoberfest topic on their repo. That makes PRs count to the Hacktoberfest (a competition) goal. It would be nice to have that here too. |
|
You can also just accept specific PRs with a corresponding label "hacktoberfest-accepted" AFAIK |
|
I've added the topic:
|
|
Thank you |
3 participants
Fixes #2029
It should also work on Android Lollipop according to this. I couldn't test it, however.
Screenshot
Signed-off-by: Constantin Wartenburger [email protected]