Feature/bca/perf better send time #2235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
force-pushed
the
feature/bca/perf_better_send_time
branch
2 times, most recently
from
9664417 to
301ff39
Compare
bmarty
reviewed
Oct 9, 2020
Member
bmarty
left a comment
bmarty
left a comment
There was a problem hiding this comment.
I made a first static review. That's amazing work!
Will try to use the code during the week-end
| .let { sendEvent(it) } | ||
| } | ||
|
|
||
| // For test only |
| private val queuedTaskFactory: QueuedTaskFactory, | ||
| private val taskExecutor: TaskExecutor, | ||
| private val memento: QueueMemento | ||
| ) : Thread("SENDER_THREAD_SID_${sessionParams.credentials.sessionId()}") { |
Member
There was a problem hiding this comment.
Have you tested the signout, if there are unsent Events?
Member
Author
There was a problem hiding this comment.
When the session is closed, the send processor will be interrupted thus pending messages won't be sent.
| * reschedule them (and only them) on next restart | ||
| */ | ||
| internal class QueueMemento @Inject constructor(context: Context, | ||
| sessionParams: SessionParams, |
| * Info that need to be persisted by the sender thread | ||
| * With polymorphic moshi parsing | ||
| */ | ||
| interface TaskInfo { |
| ) : TaskInfo | ||
|
|
||
| @JsonClass(generateAdapter = true) | ||
| data class FallbackTaskInfo( |
Member
There was a problem hiding this comment.
all those 3 data classes should have internal modifier I think
bmarty
force-pushed
the
feature/bca/perf_better_send_time
branch
from
27b1812 to
dc8a6cc
Compare
Member
Author
|
Fixes #516 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve send time performances why removing usage of workers to send events.
On some devices heavy delay were experienced when sending events ( 5s, 6s, 20s...). It's touching some devices and not others and is still a bit random.
Workers by them selves are adding a bit of delay before launching, and in addition we have to rely on database to get up to date localEchos, and such transactions are sometime very slow
Example of improvement of send time (top is with worker, bottom is with new implementation)
The current implem just uses a sender thread, that consumes send tasks in order.
Media messages are still using workers
In addition some improvement have been made on timeline with broader support of UI local echos
** Known Limitation