Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded color on save button #8208

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Conversation

jdauphant
Copy link
Contributor

@jdauphant jdauphant commented Mar 4, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Save button background color is hardcoded. Now we use the theming colors instead.

Similar to :

Motivation and context

Screenshots / GIFs

Tests

  • Edit a message

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

Signed-off-by: Julien DAUPHANT [email protected]

@jdauphant
Copy link
Contributor Author

@yostyle yostyle requested review from jmartinesp, a team and jonnyandrew and removed request for jmartinesp and a team March 6, 2023 13:05
@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label Mar 6, 2023
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change @jdauphant , can you add a sign-off so that we can merge the PR?

@jdauphant
Copy link
Contributor Author

@bmarty I have added the signoff in the pull request comment. Is that good ?

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmarty bmarty merged commit 27ed0fe into element-hq:develop Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants