-
Notifications
You must be signed in to change notification settings - Fork 861
Closed
Labels
O-OccasionalAffects or can be seen by some users regularly or most users rarelyAffects or can be seen by some users regularly or most users rarelyS-MinorImpairs non-critical functionality or suitable workarounds existImpairs non-critical functionality or suitable workarounds existT-DefectSomething isn't working: bugs, crashes, hangs and other reported problemsSomething isn't working: bugs, crashes, hangs and other reported problemsZ-ANRApplication Not RespondingApplication Not RespondingZ-UnifiedPush
Description
Steps to reproduce
When asking to select a notification method (background sync or unified push), it leads to ANR since the code is running on Main thread.
Another issue is the check of the notification method is done in the renderState() method in HomeActivity which should not be done there since this is not UI. It leads to have multiple displayed dialog at start.
Also to have better code architecture, this related code should be encapsulated into a dedicated UseCase.
Outcome
What did you expect?
To not experience ANR.
What happened instead?
ANR + strange behavior on startup of the home screen.
Your phone model
No response
Operating system version
No response
Application version and app store
No response
Homeserver
No response
Will you send logs?
No
Are you willing to provide a PR?
Yes
Metadata
Metadata
Assignees
Labels
O-OccasionalAffects or can be seen by some users regularly or most users rarelyAffects or can be seen by some users regularly or most users rarelyS-MinorImpairs non-critical functionality or suitable workarounds existImpairs non-critical functionality or suitable workarounds existT-DefectSomething isn't working: bugs, crashes, hangs and other reported problemsSomething isn't working: bugs, crashes, hangs and other reported problemsZ-ANRApplication Not RespondingApplication Not RespondingZ-UnifiedPush