Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate voice broadcast state events #7283

Merged

Conversation

Florian14
Copy link
Contributor

Type of change

  • WIP Feature
  • Bugfix
  • Technical
  • Other :

Content

Display a single voice broadcast state event in the timeline. Each change related to the voice broadcast state will update the tile of the first state event. The position of the tile remains the same.

Motivation and context

Continue #7127

Screenshots / GIFs

Before After
image vb_tile_timeline_position

Tests

  • Enable the voice broadcast feature flag
  • Start a voice broadcast in a room
  • Send several messages
  • Update the voice broadcast state (pause/resume/stop)
  • Verify that the voice broadcast tile is correctly updated and that the position of the tile has not changed

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@Florian14 Florian14 marked this pull request as ready for review October 4, 2022 09:46
@Florian14 Florian14 requested review from a team and yostyle and removed request for a team October 4, 2022 09:46
@Florian14 Florian14 force-pushed the feature/fre/voice_broadcast_state_event branch from b06c2af to 07f0069 Compare October 5, 2022 08:01
@Florian14 Florian14 force-pushed the feature/fre/aggregate_voice_broadcast_state_events branch from a8691a2 to 16b5d96 Compare October 5, 2022 08:01
@Florian14 Florian14 force-pushed the feature/fre/aggregate_voice_broadcast_state_events branch from 7c8f282 to 2813300 Compare October 6, 2022 12:22
@Florian14 Florian14 changed the base branch from feature/fre/voice_broadcast_state_event to develop October 6, 2022 12:30
@Florian14 Florian14 changed the base branch from develop to feature/fre/voice_broadcast_state_event October 6, 2022 12:30
@Florian14 Florian14 force-pushed the feature/fre/voice_broadcast_state_event branch from 987b506 to 688c908 Compare October 6, 2022 12:45
@Florian14 Florian14 force-pushed the feature/fre/voice_broadcast_state_event branch from 688c908 to b286a52 Compare October 6, 2022 14:35
@Florian14 Florian14 force-pushed the feature/fre/aggregate_voice_broadcast_state_events branch from 2813300 to 0a047b6 Compare October 6, 2022 14:35
Base automatically changed from feature/fre/voice_broadcast_state_event to develop October 7, 2022 12:53
@sonarcloud
Copy link

sonarcloud bot commented Oct 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Florian14 Florian14 merged commit b9f4740 into develop Oct 7, 2022
@Florian14 Florian14 deleted the feature/fre/aggregate_voice_broadcast_state_events branch October 7, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants