Catch error and return Result in useCases

element-hq · Oct 6, 2022 · b286a52 · b286a52
1 parent 30f33d3
commit b286a52
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/...src/main/java/im/vector/app/features/voicebroadcast/usecase/PauseVoiceBroadcastUseCase.kt b/...src/main/java/im/vector/app/features/voicebroadcast/usecase/PauseVoiceBroadcastUseCase.kt
@@ -33,8 +33,8 @@ class PauseVoiceBroadcastUseCase @Inject constructor(
         private val session: Session,
 ) {
 
-    suspend fun execute(roomId: String) {
-        val room = session.getRoom(roomId) ?: return
+    suspend fun execute(roomId: String): Result<Unit> = runCatching {
+        val room = session.getRoom(roomId) ?: error("Unknown roomId: $roomId")
 
         Timber.d("## PauseVoiceBroadcastUseCase: Pause voice broadcast requested")
 

diff --git a/...rc/main/java/im/vector/app/features/voicebroadcast/usecase/ResumeVoiceBroadcastUseCase.kt b/...rc/main/java/im/vector/app/features/voicebroadcast/usecase/ResumeVoiceBroadcastUseCase.kt
@@ -33,8 +33,8 @@ class ResumeVoiceBroadcastUseCase @Inject constructor(
         private val session: Session,
 ) {
 
-    suspend fun execute(roomId: String) {
-        val room = session.getRoom(roomId) ?: return
+    suspend fun execute(roomId: String): Result<Unit> = runCatching {
+        val room = session.getRoom(roomId) ?: error("Unknown roomId: $roomId")
 
         Timber.d("## ResumeVoiceBroadcastUseCase: Resume voice broadcast requested")
 

diff --git a/...src/main/java/im/vector/app/features/voicebroadcast/usecase/StartVoiceBroadcastUseCase.kt b/...src/main/java/im/vector/app/features/voicebroadcast/usecase/StartVoiceBroadcastUseCase.kt
@@ -32,8 +32,8 @@ class StartVoiceBroadcastUseCase @Inject constructor(
         private val session: Session,
 ) {
 
-    suspend fun execute(roomId: String) {
-        val room = session.getRoom(roomId) ?: return
+    suspend fun execute(roomId: String): Result<Unit> = runCatching {
+        val room = session.getRoom(roomId) ?: error("Unknown roomId: $roomId")
 
         Timber.d("## StartVoiceBroadcastUseCase: Start voice broadcast requested")
 

diff --git a/.../src/main/java/im/vector/app/features/voicebroadcast/usecase/StopVoiceBroadcastUseCase.kt b/.../src/main/java/im/vector/app/features/voicebroadcast/usecase/StopVoiceBroadcastUseCase.kt
@@ -33,8 +33,8 @@ class StopVoiceBroadcastUseCase @Inject constructor(
         private val session: Session,
 ) {
 
-    suspend fun execute(roomId: String) {
-        val room = session.getRoom(roomId) ?: return
+    suspend fun execute(roomId: String): Result<Unit> = runCatching {
+        val room = session.getRoom(roomId) ?: error("Unknown roomId: $roomId")
 
         Timber.d("## StopVoiceBroadcastUseCase: Stop voice broadcast requested")