Fix animated images only autoplaying sometimes #6215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
networkException
added a commit
to networkException/element-android
that referenced
this pull request
May 31, 2022
Signed-off-by: networkException <[email protected]>
networkException
force-pushed
the
fix-animated-only-fetching-thumbnail
branch
from
d74b925
to
9654c91
Compare
bmarty
requested review from
a team,
ouchadam and
bmarty
and removed request for
a team
bmarty
approved these changes
Jun 8, 2022
...src/main/java/im/vector/app/features/home/room/detail/timeline/item/MessageImageVideoItem.kt
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/media/ImageContentRenderer.kt
Outdated
Show resolved
Hide resolved
ouchadam
reviewed
Jun 8, 2022
...src/main/java/im/vector/app/features/home/room/detail/timeline/item/MessageImageVideoItem.kt
Outdated
Show resolved
Hide resolved
networkException
added a commit
to networkException/element-android
that referenced
this pull request
Jun 9, 2022
Signed-off-by: networkException <[email protected]>
networkException
force-pushed
the
fix-animated-only-fetching-thumbnail
branch
from
9654c91
to
0c13ed8
Compare
ouchadam
approved these changes
Jun 9, 2022
networkException
added a commit
to networkException/element-android
that referenced
this pull request
Jun 15, 2022
Signed-off-by: networkException <[email protected]>
networkException
force-pushed
the
fix-animated-only-fetching-thumbnail
branch
from
0c13ed8
to
18eed00
Compare
|
Updated to resolve the conflict with b3fdb5e#diff-4c7d967a761a61ec885422f0b073f89bfc930e8ba67e825af801a1ed6a28c9d5L272 |
|
Is there anything blocking this from getting merged? |
Came here to ask this as well. Would love for this to be merged! |
This patch introduces a new `ImageContentRenderer` mode used for autoplaying animated images. The mode shares url resolving semantics with `FULL_SIZE` and `STICKER`, as such not just fetching thumbnail data but shares sizing semantics with `THUMBNAIL` (scaling by image height). This change fixes animated images not playing in cases in which only a static thumbnail would be loaded. This new mode will only be chosen if the message content is actually a playable image, as such limiting bandwith usage to the required amount by avoiding to load normal images fully (still fetching animated images will increase bandwith usage as a whole of course). Signed-off-by: networkException <[email protected]>
This patch removes the dependency on `VectorSettings` as well as only enable animated rendering if the image is actually playable. Signed-off-by: networkException <[email protected]>
Signed-off-by: networkException <[email protected]>
networkException
force-pushed
the
fix-animated-only-fetching-thumbnail
branch
from
18eed00
to
2bca94d
Compare
|
@bmarty is there something missing for this to get merged? |
Just time. Thanks for the update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
This pull request fixes autoplaying animated images only actually autoplaying in some cases as only thumbnail data would be fetched in the other cases.
It introduces a new
ImageContentRenderermode specifically for animated images with thumbnail sizing that always resolves to the actual image url just like stickers for exampleThe autoplaying feature was originally introduced in #6166
Motivation and context
This issue was brought up in the element-android matrix channel after release 1.4.18
Screenshots / GIFs
Tests
Tested devices
Checklist