Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copy for "override nick colour" #5825

Closed
kittykat opened this issue Apr 22, 2022 · 4 comments · Fixed by #5831
Closed

Update copy for "override nick colour" #5825

kittykat opened this issue Apr 22, 2022 · 4 comments · Fixed by #5831
Labels
good first issue Good for newcomers help wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@kittykat
Copy link
Contributor

kittykat commented Apr 22, 2022

Steps to reproduce

  1. Click on a user to see their profile

Outcome

What did you expect?

"More" section of the screen in this order:

  • Direct message
  • Override display name colour
  • Jump to read receipt
  • Mention
  • Ignore

And the "Override" popup title is "Override display name colour"

What happened instead?

"Override" is before "message" and uses "nick" instead of "display name"

Your phone model

No response

Operating system version

No response

Application version and app store

1.4.12

Homeserver

No response

Will you send logs?

No

@kittykat kittykat added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems help wanted Extra attention is needed good first issue Good for newcomers S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Apr 22, 2022
@bmarty
Copy link
Member

bmarty commented Apr 26, 2022

(as per commented in #5831, default strings have to be US English, so we use color instead of colour)

@kittykat
Copy link
Contributor Author

kittykat commented Apr 26, 2022

(as per commented in #5831, default strings have to be US English, so we use color instead of colour)

We should revisit that on a product level as web has en_GB by default probably because most engineers are in Europe, and then there are en_US translations.

For now, could we clarify the expectation in the docs please?

@bmarty
Copy link
Member

bmarty commented Apr 26, 2022

Default to en-US is a "limitation" of the Android platform. It's still possible to provide translations for en-GB, and we already have some, see https://github.com/vector-im/element-android/blob/main/vector/src/main/res/values-en-rGB/strings.xml#L3.

Note that if your phone is configured to use en-GB, you will see the app with en-GB strings. So default language for the app will be the language set in your phone.

I will update the doc to clarify this point.

@bmarty
Copy link
Member

bmarty commented Apr 27, 2022

Clarified in 506d27f

ouchadam pushed a commit that referenced this issue May 12, 2022
- Used display name instead of nick to match other strings in the app.
- Reordered member profile to show DM above changing nick colour.

Fixes #5825

Signed-off-by: Henry Jackson <[email protected]>
piersonleo pushed a commit to piersonleo/element-android that referenced this issue Jun 7, 2022
- Used display name instead of nick to match other strings in the app.
- Reordered member profile to show DM above changing nick colour.

Fixes element-hq#5825

Signed-off-by: Henry Jackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants