Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I would not have removed the highlight, but rather limit the width of the button to avoid the effect to be full width: #5338

Closed
bmarty opened this issue Feb 24, 2022 · 3 comments
Closed

I would not have removed the highlight, but rather limit the width of the button to avoid the effect to be full width: #5338

bmarty opened this issue Feb 24, 2022 · 3 comments
Labels
A-Polls A-Theming T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Labs

Comments

@bmarty
Copy link
Member

bmarty commented Feb 24, 2022

I would not have removed the highlight, but rather limit the width of the button to avoid the effect to be full width:

image

Is it a request from the design team?

Originally posted by @bmarty in #5178 (comment)
@bmarty bmarty added the X-Needs-Design May require input from the design team label Feb 24, 2022
@bmarty
Copy link
Member Author

bmarty commented Feb 24, 2022 •
edited
Loading

I think we should revert the change from #5179 and limit the width of this button

@ouchadam ouchadam added T-Task Refactoring, enabling or disabling functionality, other engineering tasks and removed Z-Labs labels Feb 28, 2022
@gaelledel
Copy link

This is a text button so no highlight is needed here

@gaelledel gaelledel removed the X-Needs-Design May require input from the design team label Oct 5, 2022
@Johennes
Copy link
Contributor

Johennes commented Oct 5, 2022

Closing based on @gaelledel comment as it appears we'd like to not reconsider this for now.

@Johennes Johennes closed this as completed Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Polls A-Theming T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Labs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Johennes @ouchadam @bmarty @gaelledel