Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant highlight on add poll option button #5178

Closed
onurays opened this issue Feb 7, 2022 · 1 comment · Fixed by #5179
Closed

Remove redundant highlight on add poll option button #5178

onurays opened this issue Feb 7, 2022 · 1 comment · Fixed by #5179
Assignees
@onurays
Labels
A-Polls T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Labs

Comments

@onurays
Copy link
Contributor

onurays commented Feb 7, 2022

Steps to reproduce

Highlighting "add option" button seems weird.

Outcome

Remove highlight of the button

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

No
@onurays onurays added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Polls labels Feb 7, 2022
@onurays onurays self-assigned this Feb 7, 2022
@github-actions github-actions bot added the Z-Labs label Feb 7, 2022
@onurays onurays mentioned this issue Feb 7, 2022
Merged
@bmarty
Copy link
Member

bmarty commented Feb 14, 2022

I would not have removed the highlight, but rather limit the width of the button to avoid the effect to be full width:

image

Is it a request from the design team?

@bmarty bmarty mentioned this issue Feb 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onurays onurays

Labels
A-Polls T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove redundant highlight on add poll option button element-hq/element-android
2 participants
@onurays @bmarty