Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterate on badge / unread indicator color #5332

Closed
bmarty opened this issue Feb 24, 2022 · 4 comments · Fixed by #5456
Closed

Iterate on badge / unread indicator color #5332

bmarty opened this issue Feb 24, 2022 · 4 comments · Fixed by #5456
Assignees
@bmarty
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Needs-Design May require input from the design team X-Regression Z-UI UX

Comments

@bmarty
Copy link
Member

bmarty commented Feb 24, 2022

I think there is a recent change in the color that introduced some weird colors in the badge (with value "130" in the screenshots below) and undead indicator (vertical bar on left)

Light Dark
image image

In light theme it seems alright, but on dark, there is not enought contrast in the badge between text and background, and the vertical indicator color is maybe a bit too light.

@amshakal can you provide the Figma reference for a room list item in light and dark theme please?

New in release #5302
@bmarty bmarty added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-UI UX X-Regression O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Feb 24, 2022
@ouchadam ouchadam added the X-Needs-Design May require input from the design team label Feb 28, 2022
@amshakal
Copy link

amshakal commented Mar 7, 2022

Hello! Here are the reworked colours. Let me know what you think.

@bmarty bmarty self-assigned this Mar 8, 2022
@bmarty
Copy link
Member Author

bmarty commented Mar 8, 2022

We will use the ternary color. I will create a PR this morning

bmarty added a commit that referenced this issue Mar 8, 2022
@bmarty
Iterate on badge / unread indicator color (#5332)
5847f7b
bmarty added a commit that referenced this issue Mar 8, 2022
@bmarty
Iterate on badge / unread indicator color (#5332)
b867e5f
@bmarty bmarty mentioned this issue Mar 8, 2022
Merged
bmarty added a commit that referenced this issue Mar 8, 2022
@bmarty
Merge pull request #5456 from vector-im/feature/bma/fix_color
f628b24 
Iterate on badge / unread indicator color (#5332)
@bmarty
Copy link
Member Author

bmarty commented Mar 8, 2022

Fixed in 1.4.4

@bew
Copy link

bew commented Mar 14, 2022

Hello, like #5456 (comment), I still think the contrast is not enough with the dark 'after' version in #5456..
It's hard to see at-a-glance which chat has the most unread, or how much is it.
For the light 'after' version it even looks like there's less contrast than before 👀 is that intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Needs-Design May require input from the design team X-Regression Z-UI UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Iterate on badge / unread indicator color (#5332) element-hq/element-android
4 participants
@ouchadam @bmarty @bew @amshakal