Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to dowload images??? #5005

Closed
viasux opened this issue Jan 20, 2022 · 10 comments · Fixed by #5349
Closed

Unable to dowload images??? #5005

viasux opened this issue Jan 20, 2022 · 10 comments · Fixed by #5349
Assignees
Labels
A-File-Download A-Media T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Needs-Design May require input from the design team Z-Ready This issue is ready for development Z-WTF WTF moment: High Impact, Low Effort

Comments

@viasux
Copy link

viasux commented Jan 20, 2022

Steps to reproduce

  1. Click on an image
  2. Try holding your finger on it, nothing happens
  3. Try hitting share, no option to save
  4. Cant download???

Outcome

What did you expect?

The ability to download images

What happened instead?

This functionality does not seem to exist

Your phone model

Pixel 4a5g

Operating system version

Android 11 LineageOS 18.1

Application version and app store

Element Version 1.3.14 Olm Version 3.2.10

Homeserver

yiff.social

Will you send logs?

No

@viasux viasux added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jan 20, 2022
@bmarty
Copy link
Member

bmarty commented Jan 20, 2022

All is working here. Maybe only on LineageOS?

@konomikitten
Copy link

konomikitten commented Jan 20, 2022

All is working here. Maybe only on LineageOS?

Tested Element 1.3.14 here on LineageOS 14.1/17.1 on matrix.org no issues.

Friend tested 18.1, same version same instance and also had no problems.

Edit: Seems I misread the original report, this is for an image already open not in the chat log, which definitely does not have any other option but sharing, is this a UI oversight?

@kittykat
Copy link
Contributor

I can confirm that the gallery has only a share button

@viasux
Copy link
Author

viasux commented Jan 20, 2022

All is working here. Maybe only on LineageOS?

Tested Element 1.3.14 here on LineageOS 14.1/17.1 on matrix.org no issues.

Friend tested 18.1, same version same instance and also had no problems.

Edit: Seems I misread the original report, this is for an image already open not in the chat log, which definitely does not have any other option but sharing, is this a UI oversight?

Yeah, luckily found out u can hold on the message itself and hit "save" but thats hardly intuitive

@ouchadam ouchadam added A-Media X-Needs-Product Issue needs input from Product team Z-WTF WTF moment: High Impact, Low Effort labels Jan 21, 2022
@ouchadam
Copy link
Contributor

👍 I would definitely appreciate a dedicated download button/menu in the gallery view

For context

TIMELINE IMAGE VIEWER LONG PRESS
Screenshot_20220121_172748 Screenshot_20220121_172740 Screenshot_20220121_172905

looping in product @daniellekirkwood

@daniellekirkwood
Copy link
Contributor

Thanks for bringing this to my attention @ouchadam. Yes, let's go ahead and add a Save button to the gallery view.

Tagging @amshakal for review and placement confirmation.

@daniellekirkwood daniellekirkwood added X-Needs-Design May require input from the design team and removed X-Needs-Product Issue needs input from Product team labels Jan 24, 2022
@amshakal
Copy link

LGTM. Can we change the ordering over here, and move add reaction, save and share above remove? (In that particular order) Seems like if someone shares an image, the user is more likely to save or share it than remove someone else's image?

I also noticed we have the option to copy images on iOS but not on Android. Something worth adding?

@daniellekirkwood
Copy link
Contributor

Great, so when the user is on the timeline, they long press to get the context menu, that context menu ordering should be changed (as per @amshakal s comment)

Also, we want to add the save icon to the top right of the image viewer screen next to Share.

@amshakal we might need the save icon asset

@daniellekirkwood daniellekirkwood added the Z-Ready This issue is ready for development label Feb 2, 2022
@amshakal
Copy link

amshakal commented Feb 3, 2022

Link to save/download icon: https://www.figma.com/file/X4XTH9iS2KGJ2wFKDqkyed/Compound?node-id=1373%3A13

bmarty added a commit that referenced this issue Feb 28, 2022
@bmarty
Copy link
Member

bmarty commented Feb 28, 2022

In Element 1.4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-File-Download A-Media T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Needs-Design May require input from the design team Z-Ready This issue is ready for development Z-WTF WTF moment: High Impact, Low Effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants