Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The notification badge jumps around #4640

Closed
daniellekirkwood opened this issue Dec 6, 2021 · 4 comments
Closed

The notification badge jumps around #4640

daniellekirkwood opened this issue Dec 6, 2021 · 4 comments
Assignees
@ahmed-radhouane @amshakal
Labels
A-Room-List T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Ready This issue is ready for development Z-WTF WTF moment: High Impact, Low Effort
Milestone
WTF ready list

Comments

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Dec 6, 2021 •
edited
Loading

This issue is: Ready to Build

Problem

The notification badge is not in a consistent spot in the room list, and so as rooms move around (due to activity) the badges can be disorienting too.

Solution

Right align the notifications badge in the rooms list (and DMs) so that it's always in a consistent place on the screen.

Here is a mockup:

The notification badge to the right next to timestamp (8px between them). Also changed it's colour to match iOS: #737D8C on light and #A9B2BC on dark.

Screenshot 2021-12-15 at 22 01 31
@daniellekirkwood daniellekirkwood added X-Needs-Design May require input from the design team T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-WTF WTF moment: High Impact, Low Effort labels Dec 6, 2021
@amshakal amshakal mentioned this issue Dec 15, 2021
Closed
@amshakal
Copy link

Here is a mockup. Changes:

I have moved the notification badge to the right next to timestamp (8px between them), I also changed it's colour to match iOS: #737D8C on light and #A9B2BC on dark.

Screenshot 2021-12-15 at 22 01 31

@daniellekirkwood daniellekirkwood removed the X-Needs-Design May require input from the design team label Jan 4, 2022
@daniellekirkwood
Copy link
Contributor Author

Removed Needs Design label and Amsha assignment as questions answered and this issue is now ready to be built

@daniellekirkwood daniellekirkwood added the Z-Ready This issue is ready for development label Jan 26, 2022
@bmarty bmarty added this to the WTF ready list milestone Jan 31, 2022
@daniellekirkwood daniellekirkwood added Z-WTF WTF moment: High Impact, Low Effort Z-FTUE Issue is relevant to the first time use project or experience and removed Z-WTF WTF moment: High Impact, Low Effort Z-FTUE Issue is relevant to the first time use project or experience labels Feb 7, 2022
@amshakal amshakal mentioned this issue Feb 7, 2022
Closed
@ahmed-radhouane ahmed-radhouane self-assigned this Feb 8, 2022
@ahmed-radhouane
Copy link
Contributor

ahmed-radhouane commented Feb 9, 2022 •
edited
Loading

Hello, @amshakal , @daniellekirkwood

I would like to ask about the counter badge, I found it different for numbers bigger than 100 (more than 3 digits )

  • in the bottom while choosing between rooms and and DM , it is shown as +99.
  • in the rooms cells or up in the header it show the full value (exemple : 130)

Is it the an issue or this is the way to do it ?

Screenshot_20220209_103136

ahmed-radhouane added a commit that referenced this issue Feb 9, 2022
@ahmed-radhouane
#4640
ecbfc06 
 - change unread counter badge view in item_room to be in consistent place on the screen, to left of date/time.
 - change unread badge color state for dark and light theme to align with iOS.
 - add changelog file related to the issue.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
@ahmed-radhouane ahmed-radhouane mentioned this issue Feb 9, 2022
Merged
9 tasks
ahmed-radhouane added a commit that referenced this issue Feb 9, 2022
@ahmed-radhouane
#4640
14ffa65 
 - change unread counter badge view in item_room to be in consistent place on the screen, to left of date/time.
 - change unread badge color state for dark and light theme to align with iOS.
 - add changelog file related to the issue.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
ahmed-radhouane added a commit that referenced this issue Feb 11, 2022
@ahmed-radhouane
#4640
e61c3ca 
 - update changelog file.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
ahmed-radhouane added a commit that referenced this issue Feb 11, 2022
@ahmed-radhouane
#4640
a9a1532 
 - change unread counter badge view in item_room to be in consistent place on the screen, to left of date/time.
 - change unread badge color state for dark and light theme to align with iOS.
 - add changelog file related to the issue.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
ahmed-radhouane added a commit that referenced this issue Feb 11, 2022
@ahmed-radhouane
#4640
85414fa 
 - update changelog file.

Signed-off-by: Ahmed Radhouane Belkilani <[email protected]>
ouchadam added a commit that referenced this issue Feb 11, 2022
@ouchadam
Merge pull request #5189 from vector-im/arb/issues/4640
ea13f1c 
#4640 : The notification badge jumps around
@manuroe
Copy link
Member

manuroe commented Mar 1, 2022

PR merged

@manuroe manuroe closed this as completed Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahmed-radhouane ahmed-radhouane

@amshakal amshakal

Labels
A-Room-List T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Ready This issue is ready for development Z-WTF WTF moment: High Impact, Low Effort
Projects
None yet
Milestone
WTF ready list
Development

No branches or pull requests
6 participants
@ouchadam @bmarty @manuroe @ahmed-radhouane @amshakal @daniellekirkwood