Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unread marker not showing since 1.3.4 #4313

Closed
SpiritCroc opened this issue Oct 22, 2021 · 1 comment · Fixed by #4316
Closed

Unread marker not showing since 1.3.4 #4313

SpiritCroc opened this issue Oct 22, 2021 · 1 comment · Fixed by #4316
Assignees
@ganfra
Labels
A-Read-Marker O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@SpiritCroc
Copy link
Contributor

SpiritCroc commented Oct 22, 2021 •
edited
Loading

Steps to reproduce

  1. Open a chat with unread messages

Intended result and actual result

What did you expect?

Blue unread marker showing

What happened instead?

Blue unread marker missing

Expected cause

After debugging a little, it looks like the cause is that computeUnreadState() is no more called in RoomDetailViewModel.getUnreadState(). I assume the observable broke in f72a34ed08.

@bmarty is this on the 1.3.5 roadmap?
@SpiritCroc SpiritCroc added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Oct 22, 2021
@bmarty
Copy link
Member

bmarty commented Oct 22, 2021

This is a regression, I think, thanks for your investigation. We are discussing internally to decide if it is a release blocker.

@ganfra ganfra self-assigned this Oct 22, 2021
@ganfra ganfra added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Read-Marker labels Oct 22, 2021
ganfra pushed a commit that referenced this issue Oct 22, 2021
Fix unread marker not showing #4313
a82a5c9
@ganfra ganfra mentioned this issue Oct 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ganfra ganfra

Labels
A-Read-Marker O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix unread marker not showing element-hq/element-android
3 participants
@bmarty @ganfra @SpiritCroc