Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When accepting an invite, expecting to see the room #3771

Closed
jaywink opened this issue Aug 1, 2021 · 6 comments · Fixed by #5247
Closed

When accepting an invite, expecting to see the room #3771

jaywink opened this issue Aug 1, 2021 · 6 comments · Fixed by #5247
Assignees
Labels
A-DMs A-Invite Sponsored T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design May require input from the design team X-Needs-Product Issue needs input from Product team Z-D1 Issue impacts D1 metric Z-Papercuts Visible. Impactful. Predictable to action. Z-WTF WTF moment: High Impact, Low Effort

Comments

@jaywink
Copy link
Member

jaywink commented Aug 1, 2021

When I accept an invitation to a room, after the invite is processed I would expect to see the room. Instead it is hidden somewhere in my room list, forcing me to use search to find it, to find out if there are any messages there for me to react to.

@jaywink jaywink added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Aug 1, 2021
@bmarty
Copy link
Member

bmarty commented Aug 23, 2021

It's done like that to be able to accept multiple invitations in a row. If you want to enter the room, first click on the invite item (not the button), and then accept the invitation in the next screen.

@giomfo
Copy link
Member

giomfo commented Oct 6, 2021

I agree with @jaywink
I understand the purpose to accept multiple invitations, but the most common use case is to accept only one invite. This behavior seems more frustrating than useful in the real life.

@ouchadam
Copy link
Contributor

ouchadam commented Oct 6, 2021

if there is a strong case for keeping the accept without entering room then there may be a best of both worlds approach where we display a snack bar to allow the user to enter the newly accepted room (similar to an undo or updated content flow)

@manuroe
Copy link
Member

manuroe commented Oct 11, 2021

The need to accept multiple invitations in a row predates spaces.
With spaces and the auto-join of restricted rooms, there is no more need to send a bunch of invites.

@bmarty
Copy link
Member

bmarty commented Oct 11, 2021

Maybe when the user accepts an invite from the room list: open the room directly, to see it during the invite / join transition, which can take time on some servers. The user will have the possibility to go back to the room list.

Also room can be joined from the invite notification, I'm not sure we open the room in this case.

@daniellekirkwood daniellekirkwood added Z-D1 Issue impacts D1 metric X-Needs-Design May require input from the design team X-Needs-Product Issue needs input from Product team labels Oct 18, 2021
@daniellekirkwood daniellekirkwood added A-DMs Z-WTF WTF moment: High Impact, Low Effort labels Jan 11, 2022
@Florian14 Florian14 self-assigned this Jan 21, 2022
@Claire1817 Claire1817 assigned Claire1817 and unassigned Florian14 Feb 16, 2022
bmarty pushed a commit that referenced this issue Feb 18, 2022
Open the room when user accepts an invite from the room list
@bmarty
Copy link
Member

bmarty commented Feb 18, 2022

In EA 1.4.2

Also room can be joined from the invite notification, I'm not sure we open the room in this case.

This use case may be handled later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-DMs A-Invite Sponsored T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Design May require input from the design team X-Needs-Product Issue needs input from Product team Z-D1 Issue impacts D1 metric Z-Papercuts Visible. Impactful. Predictable to action. Z-WTF WTF moment: High Impact, Low Effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants