Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Functional members #3736

Closed
jaller94 opened this issue Jul 26, 2021 · 0 comments · Fixed by #8700
Closed

Support Functional members #3736

jaller94 opened this issue Jul 26, 2021 · 0 comments · Fixed by #8700
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@jaller94
Copy link
Contributor

jaller94 commented Jul 26, 2021

Is your feature request related to a problem? Please describe.

At Element we want to add bots to nameless DM rooms. These bots should not affect the dynamic room name.

A DM room with Alice, Reminder Bot and me should be called "Alice" and not "Alice and Reminder bot", given the state described below is present.

Describe the solution you'd like.

When calculating a room name:

  1. Read the room state of type io.element.functional_members. (no state key)
  2. In the content, look for an array of strings called.
  3. Exclude those user ids from the name generation.
{
    "service_members": [
        "@helperbot:localhost",
        "@reminderbot:alice.tdl"
    ]
}

Whenever the state event content gets overwritten, the room name needs to be recalculated.

Describe alternatives you've considered.

MSC2199: Canonical DMs defines unimportant users, which are likely going to accomplish the same.
However, we have an upcoming EMS product which needs this feature faster and it's still uncertain where MSC2199 is going.

Additional context

MSC-like description:
https://github.com/vector-im/element-meta/blob/develop/spec/functional_members.md

Implementation for Element Web:
matrix-org/matrix-js-sdk#1771

Issue for Element iOS:
element-hq/element-ios#4609

@jaller94 jaller94 added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Jul 26, 2021
ganfra pushed a commit that referenced this issue Dec 1, 2023
bmarty added a commit that referenced this issue Dec 4, 2023
bmarty added a commit that referenced this issue Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant