Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit In Place component #166

Merged
merged 25 commits into from
May 30, 2024
Merged

Edit In Place component #166

merged 25 commits into from
May 30, 2024

Commits on May 14, 2024

  1. WIP edit in place component

    @dbkr
    dbkr committed May 14, 2024
    Configuration menu
    Copy the full SHA
    6dfaa5f View commit details
    Browse the repository at this point in the history

  2. lint styles

    @dbkr
    dbkr committed May 14, 2024
    Configuration menu
    Copy the full SHA
    a1a062f View commit details
    Browse the repository at this point in the history

  3. Add screenshot

    @dbkr
    dbkr committed May 14, 2024
    Configuration menu
    Copy the full SHA
    c7a8d78 View commit details
    Browse the repository at this point in the history

  4. Use real buttons

    @dbkr
    dbkr committed May 14, 2024
    Configuration menu
    Copy the full SHA
    9a9b10a View commit details
    Browse the repository at this point in the history

  5. Clear timeout on unmount

    @dbkr
    dbkr committed May 14, 2024
    Configuration menu
    Copy the full SHA
    972919e View commit details
    Browse the repository at this point in the history

  6. Basic test

    @dbkr
    dbkr committed May 14, 2024
    Configuration menu
    Copy the full SHA
    6624510 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Merge branch 'main' into dbkr/editinplace

    @dbkr
    dbkr committed May 16, 2024
    Configuration menu
    Copy the full SHA
    b016a94 View commit details
    Browse the repository at this point in the history

  2. Add tests 

    and also change the inital value behaviour as I think this is probably
a bit more natural.
    @dbkr
    dbkr committed May 16, 2024
    Configuration menu
    Copy the full SHA
    4856661 View commit details
    Browse the repository at this point in the history

  3. Update snapshot

    @dbkr
    dbkr committed May 16, 2024
    Configuration menu
    Copy the full SHA
    a64a9bb View commit details
    Browse the repository at this point in the history

  4. grr, thanks for the random import, vscode

    @dbkr
    dbkr committed May 16, 2024
    Configuration menu
    Copy the full SHA
    da1d8e1 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Fix onChange & add more tests

    @dbkr
    dbkr committed May 21, 2024
    Configuration menu
    Copy the full SHA
    bb85934 View commit details
    Browse the repository at this point in the history

  2. Unfocus input on cancel

    @dbkr
    dbkr committed May 21, 2024
    Configuration menu
    Copy the full SHA
    671c4c0 View commit details
    Browse the repository at this point in the history

  3. Fix focus & missing acts in tests

    @dbkr
    dbkr committed May 21, 2024
    Configuration menu
    Copy the full SHA
    43b2585 View commit details
    Browse the repository at this point in the history

  4. Really fix focus behaviour

    @dbkr
    dbkr committed May 21, 2024
    Configuration menu
    Copy the full SHA
    98d33e4 View commit details
    Browse the repository at this point in the history

  5. Unused import

    @dbkr
    dbkr committed May 21, 2024
    Configuration menu
    Copy the full SHA
    7968593 View commit details
    Browse the repository at this point in the history

  6. Missing deps args to useCallback

    @dbkr
    dbkr committed May 21, 2024
    Configuration menu
    Copy the full SHA
    e43c4a4 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Add some stories 

    and move the url to the right place
    @dbkr
    dbkr committed May 22, 2024
    Configuration menu
    Copy the full SHA
    294558e View commit details
    Browse the repository at this point in the history

  2. Add missing screenshots

    @dbkr
    dbkr committed May 22, 2024
    Configuration menu
    Copy the full SHA
    100f4f7 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Direct control over save button disable 

    Because the error might be a failure to commit the change rather
than the input being invalid.
    @dbkr
    dbkr committed May 24, 2024
    Configuration menu
    Copy the full SHA
    e1172ac View commit details
    Browse the repository at this point in the history

  2. Add screenshots

    @dbkr
    dbkr committed May 24, 2024
    Configuration menu
    Copy the full SHA
    b4c4795 View commit details
    Browse the repository at this point in the history

  3. Remove extra screenshots

    @dbkr
    dbkr committed May 24, 2024
    Configuration menu
    Copy the full SHA
    5ef3913 View commit details
    Browse the repository at this point in the history

  4. Fix disableSaveButton in stories

    @dbkr
    dbkr committed May 24, 2024
    Configuration menu
    Copy the full SHA
    5a2e217 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Merge branch 'main' into dbkr/editinplace

    @dbkr
    dbkr authored May 30, 2024
    Configuration menu
    Copy the full SHA
    f83e3c5 View commit details
    Browse the repository at this point in the history

  2. Add playwright test for editinplace 

    So we can have a screenshot of it in its focussed state
    @dbkr
    dbkr committed May 30, 2024
    Configuration menu
    Copy the full SHA
    56a2a98 View commit details
    Browse the repository at this point in the history

  3. Don't need that screenshot

    @dbkr
    dbkr committed May 30, 2024
    Configuration menu
    Copy the full SHA
    897cabb View commit details
    Browse the repository at this point in the history