Tooltip rework#156
Merged
Merged
Conversation
Deploying compound-web with
|
| Latest commit: |
a94c9fc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f34b9ccf.compound-web.pages.dev |
| Branch Preview URL: | https://florianduros-tooltip-floatin.compound-web.pages.dev |
florianduros
force-pushed
the
florianduros/tooltip-floating-ui
branch
4 times, most recently
from
a690f4f to
dc6e18a
Compare
florianduros
force-pushed
the
florianduros/tooltip-floating-ui
branch
from
dc6e18a to
d894dfb
Compare
florianduros
force-pushed
the
florianduros/tooltip-floating-ui
branch
2 times, most recently
from
63733b8 to
e7a1ee8
Compare
4 tasks
florianduros
commented
Apr 12, 2024
Member
Author
There was a problem hiding this comment.
The focus (blue circle) is on the eye button, so the tooltip should appear, right ?
florianduros
force-pushed
the
florianduros/tooltip-floating-ui
branch
from
4669b05 to
15bf312
Compare
florianduros
force-pushed
the
florianduros/tooltip-floating-ui
branch
from
15bf312 to
a94c9fc
Compare
florianduros
requested review from
dbkr and
t3chguy
and removed request for
a team
dbkr
approved these changes
Apr 12, 2024
Member
dbkr
left a comment
dbkr
left a comment
There was a problem hiding this comment.
Phew, thanks for doing this - certainly looks like an improvement at least: nice that it doesn't <TooltipProvider>s everywhwere. Lets hope it works out better too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes element-hq/compound#298
Migrate the current tooltip implementation from radix to floating-ui.
The tooltip props has changed, the next release should be a major release:
side,align&placementsideandalignplacementwhich is basicallysideandalignmerged in one propsonEscapeKeyDown&onPointerDownOutsideare partially replaced byonOpenChange. Currently they are not used in thereact-sdk.