Fix Menu focus after closing

[florianduros]

In matrix-org/matrix-react-sdk#12136 , we are building the TAC (Threads Activity Centre) with the Menu component. We have the current issue: when the TAC is closing, the button is the Spaces has his tooltip displayed again. (You can see the tooltip Fils de discussion at the bottom left)

Enregistrement.de.l.ecran.2024-02-06.a.17.26.39.mov

Because the focus is set on the Menu trigger when the Menu is closing. According to the https://www.radix-ui.com/primitives/docs/components/dropdown-menu#content onCloseAutoFocus property:

Event handler called when focus moves to the trigger after closing. It can be prevented by calling event.preventDefault.

Adding event.preventDefault() stops the Menu trigger to have the focus after the Menu closing

[t3chguy]

This change seems to go against the WAI ARIA guidelines which say

Close the menu that contains focus and return focus to the element or context, e.g., menu button or parent menuitem, from which the menu was opened.

https://www.w3.org/WAI/ARIA/apg/patterns/menubar/

[robintown]

Agreed, I think the correct solution would instead be to apply a fix like this: matrix-org/matrix-react-sdk#8546