Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unread icons. #80

Merged
merged 3 commits into from
May 20, 2024
Merged

Add unread icons. #80

merged 3 commits into from
May 20, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented May 14, 2024

Adds Unread and Read icons.

Discussed with @amshakal about whether we should rename these to something more descriptive in case we have more things that need read/unread iconography in the future, so if that happens the icons would need renaming, otherwise this is ready for review. Please feel free to merge after reviewing 🙂

@pixlwave pixlwave marked this pull request as ready for review May 15, 2024 11:51
@pixlwave pixlwave requested a review from jmartinesp May 15, 2024 16:31
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons look fine on Android and the generated code makes sense.

However, at a personal level I think the icons are a bit weird since they're meant for email . In some other apps I've seen something like this used instead:

Screenshot_2024-05-16-08-44-38-85_79aa9bf7c61e266c5f841e42245e214b

Although arguably this can also be misleading because we don't have the concepts of 'checks' in the app.

Anyway, I'm approving this since it's not a big deal.

@amshakal
Copy link

I have changes the names in the compound file.

As far as the email analogy is concerned, yeah it's true, it's taken from an email context, but at least we would be using standard known icons to represent the features. An alternative could be to use a message bubble with a dot and without a dot. But usability wise, it shouldn't matter.

@pixlwave
Copy link
Member Author

Alright, updated with the rename 👍

@pixlwave pixlwave merged commit 5086370 into main May 20, 2024
@pixlwave pixlwave deleted the doug/unread-icons branch May 20, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants