-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1440x1440 photo display in SwiperSlider #95
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
В общем все ок. Исправь только эти мелочи. И добавь такой же фильтр картин для слайдера на странице public-page.
@@ -24,9 +24,18 @@ export const SwiperSlider = ({ imagesUrl }: Props) => { | |||
style={{ height: '100%', width: '100%' }} | |||
> | |||
{imagesUrl?.map((image: any, index: number) => { | |||
if (image.width !== 1440) return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return null лучше. Render функция должна возвращать объект (компонент в данном случае). Null - это отсутствующий объект. А если просто return, то получается undefined
@@ -44,17 +44,17 @@ export const FilteringData: FC<Props> = ({ isOpenFilter }) => { | |||
{croppers.map(post => { | |||
return ( | |||
<SwiperSlide key={post.id}> | |||
<div className={s.box}> | |||
<div style={{ position: 'relative' }} className={s.box}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тут лучше добавить стиль в класс box, если это будет работать (нет проблем с приоритетом селекторов), то дальше и везде сделай так.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All done
run build production |
No description provided.