Rollback redlock

[felixrieseberg]

In #133, I've upgraded all dependencies, including node-redlock. We've discovered that the service fails to release locks under load:

2023-05-24T17:23:46.163885+00:00 app[web.1]: node:internal/process/promises:288
2023-05-24T17:23:46.163886+00:00 app[web.1]: triggerUncaughtException(err, true /* fromPromise */);
2023-05-24T17:23:46.163886+00:00 app[web.1]: ^
2023-05-24T17:23:46.165413+00:00 app[web.1]: LockError: Unable to fully release the lock on resource "locks:freebie-frenzy/freebie-frenzy-releases".
2023-05-24T17:23:46.165414+00:00 app[web.1]: at loop (/app/node_modules/redlock/redlock.js:282:18)
2023-05-24T17:23:46.165414+00:00 app[web.1]: at Object.callback (/app/node_modules/redlock/redlock.js:462:10)
2023-05-24T17:23:46.165414+00:00 app[web.1]: at /app/node_modules/@redis/client/dist/lib/client/index.js:431:39
2023-05-24T17:23:46.165415+00:00 app[web.1]: at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
2023-05-24T17:23:46.165415+00:00 app[web.1]: attempts: undefined
2023-05-24T17:23:46.165416+00:00 app[web.1]: }

Other people discovered similar issues using node-redlock >v4.. The module author never quite figured out what exactly was wrong - instead, they did a complete rewrite of node-redlock. Sadly, that rewrite no longer supports node-redis.

In an attempt to keep things simple, I'm simply rolling back node-redlock.

[felixrieseberg]

✅ Verified on staging.update.electronjs.org