Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: timeout release job after 1 hour #285

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Conversation

dsanders11
Copy link
Member

The GH token acquired during the continuousauth/action step is only good for 1 hour, and if a maintainer provides a CFA token after that time we end up with the npm publish going through but none of the follow-up steps on GitHub (creating the release, commenting on PRs, etc). So let's timeout this job after 1 hour to prevent this edge case.

@dsanders11 dsanders11 requested review from a team as code owners November 13, 2024 20:08
@malept
Copy link
Member

malept commented Nov 13, 2024

@dsanders11 if it's possible, would it make more sense to set that as a default in continuousauth/action?

@dsanders11 dsanders11 closed this Nov 13, 2024
@dsanders11
Copy link
Member Author

@malept, good call, yea, I believe I can set it there.

@dsanders11 dsanders11 deleted the ci/timeout-release-job branch November 13, 2024 20:31
@dsanders11 dsanders11 restored the ci/timeout-release-job branch November 14, 2024 22:02
@dsanders11 dsanders11 reopened this Nov 14, 2024
@dsanders11
Copy link
Member Author

Re-hydrated this PR. While putting it as the default in continuousauth/action would have been ideal, it's not supported at that level so I had to roll it back in continuousauth/action#8.

@dsanders11 dsanders11 merged commit 7dbd4e3 into main Nov 14, 2024
8 checks passed
@dsanders11 dsanders11 deleted the ci/timeout-release-job branch November 14, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants