Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: features.isDesktopCapturerEnabled error #166

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

codebytere
Copy link
Member

Refs #154

See #154 (comment):

When features no longer contains isDesktopCapturerEnabled, !features.isDesktopCapturerEnabled evaluates to true, which then means the conditional checks the third condition: features.isDesktopCapturerEnabled() which throws an error:

Uncaught TypeError: features.isDesktopCapturerEnabled is not a function

@codebytere codebytere requested a review from miniak October 8, 2023 20:45
@codebytere codebytere requested review from a team as code owners October 8, 2023 20:45
@codebytere codebytere changed the title fix: features.isDesktopCapturerEnabled error fix: features.isDesktopCapturerEnabled error Oct 8, 2023
src/common/module-names.ts Outdated Show resolved Hide resolved
@codebytere codebytere merged commit 168b467 into main Oct 9, 2023
2 of 3 checks passed
@codebytere codebytere deleted the fix-error-desktopcapturer branch October 9, 2023 07:51
@continuous-auth
Copy link

🎉 This PR is included in version 2.0.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

taratatach added a commit to cozy-labs/cozy-desktop that referenced this pull request Mar 29, 2024
taratatach added a commit to cozy-labs/cozy-desktop that referenced this pull request Jul 29, 2024
taratatach added a commit to cozy-labs/cozy-desktop that referenced this pull request Aug 2, 2024
taratatach added a commit to cozy-labs/cozy-desktop that referenced this pull request Aug 2, 2024
taratatach added a commit to cozy-labs/cozy-desktop that referenced this pull request Sep 17, 2024
taratatach added a commit to cozy-labs/cozy-desktop that referenced this pull request Sep 17, 2024
taratatach added a commit to cozy-labs/cozy-desktop that referenced this pull request Sep 18, 2024
taratatach added a commit to cozy-labs/cozy-desktop that referenced this pull request Sep 18, 2024
taratatach added a commit to cozy-labs/cozy-desktop that referenced this pull request Sep 19, 2024
taratatach added a commit to cozy-labs/cozy-desktop that referenced this pull request Oct 2, 2024
taratatach added a commit to cozy-labs/cozy-desktop that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants