Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linux ARMv7 support #474

Merged
merged 3 commits into from
Sep 3, 2016
Merged

Add Linux ARMv7 support #474

merged 3 commits into from
Sep 3, 2016

Conversation

malept
Copy link
Member

@malept malept commented Aug 29, 2016

Have you read the section in CONTRIBUTING.md about pull requests?

Yes

Summarize your changes:

Electron has had Linux ARM support since 0.29.0, but I have been hesitant to merge any PRs for it until Electron properly tagged its downloads with the correct version of the ARM processor that it supports1. In this case, ARMv7. Fortunately, this is now on the horizon.

However, according to the Electron PR, the properly named ARM builds will only be backported to versions >= 1.0.0. We will support Electron versions 0.29.0 and above by modifying the arguments passed to electron-download to use the old name when the Electron version is less than 1.0.0. This means that a new dependency is required: semver, which checks what Electron version is being specified.

_Blocked by the release of electron/electron#6986_ (cc @kevinsawicki 😄).
Fixes #106.
Closes #107, #423.

Are your changes appropriately documented?

Added documentation about the new supported arch to the CLI and API docs, readme, and NEWS.

Do your changes have sufficient test coverage?

Updated the relevant multitarget tests.

Does the testsuite pass successfully on your local machine?

Yes

1: It didn't help that the PRs in question didn't have corresponding tests/docs.

TODO

  • Fix superfluous download option warnings
  • Uncomment semver code (and use semver.lt)

@malept malept added enhancement Feature request blocked 🚫 Depends on another issue either in this project or a dependency's project labels Aug 29, 2016
@malept malept added this to the 8.0.0 milestone Aug 29, 2016
@malept malept force-pushed the add-arm-support branch 2 times, most recently from 6a0cfc5 to 2dfb8d4 Compare August 31, 2016 01:05
@Gitelaus
Copy link

Gitelaus commented Aug 31, 2016

Looks like electron just pulled electron/electron#6986 so I assume this is now plausibly unblocked?

@malept
Copy link
Member Author

malept commented Aug 31, 2016

Nope, I can't continue work until they actually release a new version, including backporting the old 1.0+ versions per the description of the blocking PR. This is why I amended the PR description earlier this morning to add "the release of", which is different from merging.

@Gitelaus
Copy link

@malept ah okay, my apologies! I think I just got a little too excited and jumped the gun. I'll take the chance to say thanks for all the work you've put in thus far.

@malept malept changed the title [WIP] Add Linux ARMv7 support Add Linux ARMv7 support Sep 3, 2016
@malept malept removed the blocked 🚫 Depends on another issue either in this project or a dependency's project label Sep 3, 2016
@malept malept merged commit 65c5b67 into electron:master Sep 3, 2016
@malept malept deleted the add-arm-support branch September 3, 2016 17:30
@malept malept mentioned this pull request Sep 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants