Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you read the section in CONTRIBUTING.md about pull requests?
Yes
Summarize your changes:
Electron has had Linux ARM support since 0.29.0, but I have been hesitant to merge any PRs for it until Electron properly tagged its downloads with the correct version of the ARM processor that it supports1. In this case, ARMv7. Fortunately, this is now on the horizon.
However, according to the Electron PR, the properly named ARM builds will only be backported to versions >= 1.0.0. We will support Electron versions 0.29.0 and above by modifying the arguments passed to
electron-download
to use the old name when the Electron version is less than 1.0.0. This means that a new dependency is required:semver
, which checks what Electron version is being specified._Blocked by the release of electron/electron#6986_ (cc @kevinsawicki 😄).
Fixes #106.
Closes #107, #423.
Are your changes appropriately documented?
Added documentation about the new supported arch to the CLI and API docs, readme, and NEWS.
Do your changes have sufficient test coverage?
Updated the relevant multitarget tests.
Does the testsuite pass successfully on your local machine?
Yes
1: It didn't help that the PRs in question didn't have corresponding tests/docs.
TODO
semver.lt
)