CLI argument parsing code refactor #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the CLI argument parsing code to be unit tested. Add unit tests for most of the argument corner cases.
This should remove the consistent deprecation message.
malept
force-pushed
the
cli-args-refactor
branch
from
2d031e9 to
5229412
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves CLI argument parsing code to the common module. This allows the CLI argument parsing code to be unit tested (of which, tests for some corner cases have been added).
Also uses
aliasfor the deprecated--strict-sslflag. This should remove the consistent deprecation message. [1] [2]My intention is to release 7.0.1 once this is merged.
TODO