-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for child entitlements #278
Conversation
Thanks for the contribution! Could you please add an entry to |
I didn't re-indent the whole file right away, it pushes everything very far to the right, what do you think @malept ? |
Hmm. Try moving the description to the next line. Also, un-capitalize "The", it's inconsistent with the rest of the argument descriptions. |
028d945
to
4e92e03
Compare
ah, I even looked at the capitals and thought it should be small. |
|
||
`sign-entitlements-inherit` - *String* | ||
|
||
The path to the 'child' entitlements. See [electron-osx-sign](https://www.npmjs.com/package/electron-osx-sign) for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a more accurate link: https://www.npmjs.com/package/electron-osx-sign#opts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, you should add the same caveat as sign-entitlements
:
(Currently limited to Mac App Store distribution.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@malept The signing with entitlements should now work fine with darwin
builds in the latest electron-osx-sign v0.3.0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sethlu thanks for the correction. I guess the caveat needs to be removed from the entitlements
docs, then. That can happen outside of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@malept That may be better I think.
I'll find a way to explain the entitlements for darwin
builds as they, apart from sandboxing an app, do not actually do much except interacting with iCloud services, iAP or things like that. It's pretty hard to access some of these Apple services with current builds of Electron, so basically entitlements could be ignored for darwin
. The default entitlements for darwin
is blank: If a darwin
build is sandboxed, it should not also really function properly in the presence of frameworks like Squirrel.framework
.
Looks good. Squash the commits and I'll merge. |
68336ed
to
623b068
Compare
@malept squashed |
Thanks! |
Add option for child entitlements
Allows the
entitlements-inherit
option ofelectron-osx-sign
to be passed.Related to #271