adds tmpdir option to fix #203
#230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Perhaps add a test to make sure the option works as expected? |
|
@malept Any idea what might have caused the one test to fail? Doesn't seem related to my changes. |
|
That particular test intermittently fails (and I don't know why). Don't worry about it. |
|
Alright, thanks. I'll add a test in a bit and push again. |
|
@malept Test added |
| @@ -207,6 +207,10 @@ If the file extension is omitted, it is auto-completed to the correct extension | |||
|
|
|||
| Whether SSL certificates are required to be valid when downloading Electron. **Defaults to `true`**. | |||
|
|
|||
| `tmpdir` - *String* | |||
There was a problem hiding this comment.
Minor nit - this is the wrong indentation. There should be no spaces between the beginning of the line and the option name. The description's indentation is fine.
|
Would you mind rebasing and squashing the commits after you fix the minor docs issue? |
eugirdor
force-pushed
the
feature/configurable-temp-directory
branch
from
ab9042b to
ee32807
Compare
eugirdor
force-pushed
the
feature/configurable-temp-directory
branch
from
ee32807 to
b2ce937
Compare
|
@malept Whitespace fixed and commits squashed |
malept
added a commit
that referenced
this pull request
Jan 19, 2016
…tory adds `tmpdir` option to fix #203
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom temporary directory can be supplied in
opts.tmpdiror from the command line switch--tmpdir. This address issue #203.