fix: copyTemplate failed if tmpdir set to false

[ianho]

• I have read the contribution documentation for this project.
• I agree to follow the code of conduct that this project follows, as appropriate.
• The changes are appropriately documented (if applicable).
• The changes have sufficient test coverage (if applicable).
• The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

if tmpdir set to false, fs-extra copy api will throw a error that Cannot copy 'xxx' to a subdirectory of itself, 'xxx/out/xxx'.

so we cant call fs.copy in this case, traverse first-level directories to call fs.copy instead

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa6fd4c) 92.03% compared to head (513e087) 91.90%.
Report is 18 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1657      +/-   ##
==========================================
- Coverage   92.03%   91.90%   -0.13%     
==========================================
  Files          16       16              
  Lines         854      865      +11     
  Branches      167      171       +4     
==========================================
+ Hits          786      795       +9     
- Misses         51       52       +1     
- Partials       17       18       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[BlackHole1]

Thank you for your PR!
It would be better if you could explain in detail in the PR why this issue occurred. From the existing PR description and code changes, it is difficult for me to understand the reason behind them. I only understood the reason after reviewing the source code of fs.copy (because the condition is checked before the filter).

[BlackHole1]

Suggested change

filter,

Since the judgment has already been made before, there is no need to let fs.copy execute the judgment again.

[BlackHole1]

PTAL @malept @erikian

[erickzhao]

Hey @ianho, we discussed this in an Ecosystem WG meeting and I think this PR is the best solution for https://github.com/electron/forge/issues/3475 as well since it resolves the problem upstream.

Two blockers here:

• Can we add a comment explaining why this is necessary about line 156?
• We should add a test for this code so it doesn't regress in the future.