Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: proper npm and Xcode capitalization #1438

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

friederbluemle
Copy link
Contributor

@welcome
Copy link

welcome bot commented Oct 30, 2022

Thanks for opening a pull request!

Here are some highlighted action items that will help get it across the finish line, from the
pull request guidelines:

  • Follow the JavaScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes in NEWS.md and other docs.
  • Include tests when adding/changing behavior.

Development and triage is community-driven, so please be patient and we will get back to you as soon as we can.

@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Merging #1438 (5ce6124) into main (5aac8c9) will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1438      +/-   ##
==========================================
+ Coverage   95.41%   95.54%   +0.12%     
==========================================
  Files          15       15              
  Lines         785      785              
==========================================
+ Hits          749      750       +1     
+ Misses         36       35       -1     
Impacted Files Coverage Δ
src/copy-filter.js 100.00% <0.00%> (+2.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erickzhao erickzhao changed the title Fix typos chore: proper npm and Xcode capitalization Nov 1, 2022
@VerteDinde VerteDinde merged commit 609b8d0 into electron:main Nov 2, 2022
@welcome
Copy link

welcome bot commented Nov 2, 2022

Thanks for your contribution! 🎉

@friederbluemle friederbluemle deleted the fix-typos branch November 3, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants