-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: properly import info logger #1405
Conversation
Thanks for opening a pull request! Here are some highlighted action items that will help get it across the finish line, from the
Development and triage is community-driven, so please be patient and we will get back to you as soon as we can. |
Removed Common and added info in the imports.
Codecov Report
@@ Coverage Diff @@
## main #1405 +/- ##
=======================================
Coverage 95.61% 95.61%
=======================================
Files 15 15
Lines 776 776
=======================================
Hits 742 742
Misses 34 34
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
It'd be nice if there was a end to end test which caught this in the future |
Thanks for your contribution! 🎉 |
@Karangoyal25892 This is fixed in 16.0.0 - the major bump is dropping Node 10 & 12 support, and adding Node 16 & 18. Thanks for reporting this! |
@VerteDinde Whether it is possible to publish 15.5.3 with this fix, cause the bug in 15.5.2 will fail builds with |
Fixes #1404
Common is not imported in the cli.js.
so builds are failing.