-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add TypeScript definition #1131
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1131 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 712 712
=========================================
Hits 712 712 Continue to review full report at Codecov.
|
malept
force-pushed
the
typescript-definition
branch
from
February 29, 2020 07:41
67d1015
to
8d28e1c
Compare
Based on `@types/electron-packager`, it's updated for 14.2.1. It replaces `docs/api.md` as the canonical API documentation.
malept
force-pushed
the
typescript-definition
branch
2 times, most recently
from
February 29, 2020 08:54
e04e2ec
to
1b2dd58
Compare
malept
force-pushed
the
typescript-definition
branch
from
February 29, 2020 09:09
1b2dd58
to
ef72f43
Compare
malept
added a commit
to malept/electron
that referenced
this pull request
Feb 29, 2020
* Grammar fixes * Add links for Electron Packager & Electron Forge * Update Packager API links, given electron/packager#1131
malept
added a commit
to malept/electron
that referenced
this pull request
Mar 2, 2020
* Grammar fixes * Add links for Electron Packager & Electron Forge * Update Packager API links, given electron/packager#1131
4 tasks
MarshallOfSound
added a commit
to electron/electron
that referenced
this pull request
Mar 5, 2020
* docs: clean up systemPreferences.effectiveAppearance text * Grammar fixes * Add links for Electron Packager & Electron Forge * Update Packager API links, given electron/packager#1131 * docs: clean up Dark Mode guide * Grammar fixes * Add links for Electron Packager & Electron Forge * docs: adjust based on Electron 8 using 10.14 SDK
trop bot
pushed a commit
to electron/electron
that referenced
this pull request
Mar 5, 2020
* Grammar fixes * Add links for Electron Packager & Electron Forge * Update Packager API links, given electron/packager#1131
zcbenz
pushed a commit
to electron/electron
that referenced
this pull request
Mar 6, 2020
* docs: clean up systemPreferences.effectiveAppearance text * Grammar fixes * Add links for Electron Packager & Electron Forge * Update Packager API links, given electron/packager#1131 * docs: clean up Dark Mode guide * Grammar fixes * Add links for Electron Packager & Electron Forge * docs: adjust based on Electron 8 using 10.14 SDK Co-authored-by: Mark Lee <[email protected]>
5 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
Based on
@types/electron-packager
, it's updated for 14.2.1. It replacesdocs/api.md
as the canonical API documentation (docs/api.md
remains with a link-based redirect for links to the Markdown file).I've tested this definition with Electron Forge locally.
Additionally, this adds a GitHub Action to build the docs for master & tags, and publishes them to GitHub Pages.