You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Perhaps on Windows, the file-version and product-version should both default to app-version initially but file-version should still be overrideable by build-version when it is present.
This would make the app-version defaulting to the package.jsonversion value introduced in #449 be more consistent on Windows and Mac.
The text was updated successfully, but these errors were encountered:
Please describe your issue:
On Mac, both plist version keys are set to the
app-version
option when present, https://github.com/electron-userland/electron-packager/blob/9134f7be4678fdf0144bbb6b00f2da4756566415/mac.js#L109-L111 so you can just set theapp-version
option when you want the app version and build version to have the same value, but you can still overridebuild-version
when needed.This is not happening on Windows, https://github.com/electron-userland/electron-packager/blob/9134f7be4678fdf0144bbb6b00f2da4756566415/win32.js#L36-L42
Perhaps on Windows, the
file-version
andproduct-version
should both default toapp-version
initially butfile-version
should still be overrideable bybuild-version
when it is present.This would make the
app-version
defaulting to thepackage.json
version
value introduced in #449 be more consistent on Windows and Mac.The text was updated successfully, but these errors were encountered: