Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build version should default to app version on Windows #498

Closed
kevinsawicki opened this issue Sep 27, 2016 · 1 comment
Closed

Build version should default to app version on Windows #498

kevinsawicki opened this issue Sep 27, 2016 · 1 comment
Assignees
Labels
build-target:windows Bundling an Electron app specifically for Windows enhancement Feature request

Comments

@kevinsawicki
Copy link
Contributor

Please describe your issue:

On Mac, both plist version keys are set to the app-version option when present, https://github.com/electron-userland/electron-packager/blob/9134f7be4678fdf0144bbb6b00f2da4756566415/mac.js#L109-L111 so you can just set the app-version option when you want the app version and build version to have the same value, but you can still override build-version when needed.

This is not happening on Windows, https://github.com/electron-userland/electron-packager/blob/9134f7be4678fdf0144bbb6b00f2da4756566415/win32.js#L36-L42

Perhaps on Windows, the file-version and product-version should both default to app-version initially but file-version should still be overrideable by build-version when it is present.

This would make the app-version defaulting to the package.json version value introduced in #449 be more consistent on Windows and Mac.

@kevinsawicki kevinsawicki added enhancement Feature request build-target:windows Bundling an Electron app specifically for Windows labels Sep 27, 2016
@malept
Copy link
Member

malept commented Sep 27, 2016

I don't have a problem with adding this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-target:windows Bundling an Electron app specifically for Windows enhancement Feature request
Projects
None yet
Development

No branches or pull requests

2 participants