Skip to content

Commit

Permalink
Update docs/tests due to rcedit upgrade
Browse files Browse the repository at this point in the history
  • Loading branch information
malept committed Apr 10, 2016
1 parent ddab74a commit 3256b1d
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 12 deletions.
7 changes: 7 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@
## Unreleased


## [6.0.2] - 2016-04-09

### Changed

* [win32] `rcedit` dependency updated to 0.5.x. **The DLL mentioned in the 6.0.1 release notes
is no longer required.**

## [6.0.1] - 2016-04-08

### Changed
Expand Down
6 changes: 0 additions & 6 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,6 @@ The `Foo Bar.app` folder generated can be executed by a system running OS X, whi

Building an Electron app for the Windows platform with a custom icon requires editing the `Electron.exe` file. Currently, electron-packager uses [node-rcedit](https://github.com/atom/node-rcedit) to accomplish this. A Windows executable is bundled in that node package and needs to be run in order for this functionality to work, so on non-Windows host platforms, [Wine](https://www.winehq.org/) needs to be installed. On OS X, it is installable via [Homebrew](http://brew.sh/).

As of `node-rcedit` 0.4.0, an additional DLL is required, `MSVCP120.dll`. This is available in the [Microsoft Visual C++ 2013 Redistributable Package](https://www.microsoft.com/en-us/download/details.aspx?id=40784), but the easiest way to install it is to use [winetricks](https://github.com/Winetricks/winetricks):

```sh
winetricks -q vcrun2013
```

## Related

- [electron-builder](https://www.npmjs.com/package/electron-builder) - for creating installer wizards
Expand Down
7 changes: 1 addition & 6 deletions test/ci/before_install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@ case "$TRAVIS_OS_NAME" in
# Chrome source does not work because they no longer support i386
sudo rm /etc/apt/sources.list.d/google-chrome.list*
sudo apt-get update
sudo apt-get install --no-install-recommends --yes wine1.6 winetricks
# 20140817
wget -q https://raw.githubusercontent.com/Winetricks/winetricks/fa9e42955dbdf780240dedf9057295264fddd98f/src/winetricks
chmod +x winetricks
./winetricks --version
./winetricks -q vcrun2013
sudo apt-get install --no-install-recommends --yes wine1.6
;;
esac

0 comments on commit 3256b1d

Please sign in to comment.