Skip to content

ci: bump electron/secret-service-action to v1.1.0 - #466

Merged
MarshallOfSound merged 1 commit into
mainfrom
bump-secret-service-action-v1.1.0
Oct 22, 2026
Merged

MarshallOfSound merged 1 commit into
mainfrom
bump-secret-service-action-v1.1.0

Conversation

@claude

@claude claude Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Requested by Samuel Attard · Slack thread

Bumps secret-service-action to v1.1.0, which points the secret exchange at secret-service's new home on ionic (secret-service.electronjs.org) instead of Heroku.


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ELojQikqpZ2KVGqjEeNwUe
@claude
claude Bot requested a review from a team as a code owner October 22, 2026 21:37

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and didn't find any bugs. This action hands the release job its GitHub token, so a human should still confirm the new pinned commit, preferably someone from the code owners.

What was reviewed:

  • The one-line change to .github/workflows/release.yml keeps the action pinned to a full commit SHA with a version comment, which matches how the other actions in the file are pinned.
  • The step id (secret-service) and how outputs.secrets is read by the semantic-release step are the same as before.
  • I couldn't check from this checkout that 23b9042f… is the upstream v1.1.0 tag, or what changed in the action between the two commits. A human should check that upstream.
Extended reasoning...

The change bumps the SHA-pinned electron/secret-service-action from v1.0.0 to v1.1.0 in the release workflow. That action exchanges the job's OIDC identity (the job has id-token: write) for the GitHub token used to publish releases. The PR says the action now calls a new secret-service host, so this is credential-handling code in the release path. The workflow change itself is a correct mechanical bump, but I couldn't inspect the upstream diff between the two commits. A catch-all CODEOWNERS entry also covers this file, which is why I deferred instead of approving.

@MarshallOfSound
MarshallOfSound enabled auto-merge (squash) October 22, 2026 21:42
@MarshallOfSound
MarshallOfSound merged commit 0fa0e3f into main Oct 22, 2026
10 checks passed
@MarshallOfSound
MarshallOfSound deleted the bump-secret-service-action-v1.1.0 branch October 22, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants