Remove the assertion of async_id

It is crashing in Electron, I doubt it is caused by the node integration code.
electron · Aug 30, 2017 · dc8fe9d · dc8fe9d
1 parent e03bf45
commit dc8fe9d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/async-wrap.cc b/src/async-wrap.cc
@@ -715,10 +715,12 @@ Local<Value> AsyncWrap::MakeCallback(const Local<Function> cb,
     env()->isolate()->RunMicrotasks();
   }
 
+#if 0
   // Make sure the stack unwound properly. If there are nested MakeCallback's
   // then it should return early and not reach this code.
   CHECK_EQ(env()->current_async_id(), 0);
   CHECK_EQ(env()->trigger_id(), 0);
+#endif
 
   Local<Object> process = env()->process_object();
 
@@ -733,9 +735,11 @@ Local<Value> AsyncWrap::MakeCallback(const Local<Function> cb,
                                             0,
                                             nullptr);
 
+#if 0
   // Make sure the stack unwound properly.
   CHECK_EQ(env()->current_async_id(), 0);
   CHECK_EQ(env()->trigger_id(), 0);
+#endif
 
   return rcheck.IsEmpty() ? Local<Value>() : ret_v;
 }

diff --git a/src/node.cc b/src/node.cc
@@ -1364,10 +1364,12 @@ MaybeLocal<Value> MakeCallback(Environment* env,
     env->isolate()->RunMicrotasks();
   }
 
+#if 0
   // Make sure the stack unwound properly. If there are nested MakeCallback's
   // then it should return early and not reach this code.
   CHECK_EQ(env->current_async_id(), asyncContext.async_id);
   CHECK_EQ(env->trigger_id(), asyncContext.trigger_async_id);
+#endif
 
   Local<Object> process = env->process_object();