Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle missing local version binaries #807

Merged
merged 1 commit into from
Jul 26, 2021
Merged

fix: handle missing local version binaries #807

merged 1 commit into from
Jul 26, 2021

Conversation

codebytere
Copy link
Member

Fixes an issue where deleted local Electron versions would show up as non-downloaded versions in settings.

Before:

Screen Shot 2021-07-26 at 8 54 17 PM

After:

Screen Shot 2021-07-26 at 8 54 49 PM

@codebytere codebytere requested a review from ckerr July 26, 2021 18:55
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 94.507% when pulling 904df83 on fix-missing-local-version into a479300 on master.

@codebytere codebytere merged commit 93501c1 into master Jul 26, 2021
@codebytere codebytere deleted the fix-missing-local-version branch July 26, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebytere @coveralls @ckerr