Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: check download links daily #1540

Merged
merged 1 commit into from
Feb 6, 2024
Merged

ci: check download links daily #1540

merged 1 commit into from
Feb 6, 2024

Conversation

dsanders11
Copy link
Member

We've broken the download links on the website a few times and not noticed, so let's add some lightweight automation to confirm the links aren't 404ing after a new release.

Refs:

@dsanders11 dsanders11 requested review from codebytere and a team as code owners February 1, 2024 17:08
@coveralls
Copy link

coveralls commented Feb 1, 2024

Coverage Status

coverage: 87.213%. remained the same
when pulling 56ba01b on check-download-links
into 8d0b8c2 on main.

Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The site is currently built on a cron if no new commits come in, so Fiddle download links get updated periodically instead of immediately on publish.

To make this work, I think we would need to dispatch https://github.com/electron/electron-website-updater events for Fiddle builds in the same way that we trigger commits every time the e/e docs update.

@dsanders11
Copy link
Member Author

Good catch, I'd forgotten the links won't update on the website immediately.

To make this work, I think we would need to dispatch https://github.com/electron/electron-website-updater events for Fiddle builds in the same way that we trigger commits every time the e/e docs update.

There'd still be an indeterminate delay after the release was published before that website build would finish and go live, which risks the check not reviewing the latest state, which could provide a false negative.

How about for simplicity we just put this on a cron as well (say 1 AM PT)? That would catch broken download links faster than we currently do.

@dsanders11 dsanders11 changed the title ci: check download links after new release published ci: check download links daily Feb 6, 2024
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM :shipit:

@dsanders11 dsanders11 merged commit 6b4b8e5 into main Feb 6, 2024
10 checks passed
@dsanders11 dsanders11 deleted the check-download-links branch February 6, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants