test: increase timeout in ElectronTypes watch test #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsanders11
force-pushed
the
increase-test-timeout
branch
2 times, most recently
from
d5ced11
to
e27f3b9
Compare
dsanders11
force-pushed
the
increase-test-timeout
branch
from
e27f3b9
to
6507bbc
Compare
ckerr
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticing this test started flaking after #1533, I think the filesystem operations in that test is delayed when it's running under Rosetta, causing the flaky timeout. Doing a quick and dirty bump of the timeout to mitigate the flake for now.